Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[202205] [Mellanox] Fix issue: user must set admin down before toggling LPM #14370

Merged
merged 4 commits into from
Mar 24, 2023
Merged

[202205] [Mellanox] Fix issue: user must set admin down before toggling LPM #14370

merged 4 commits into from
Mar 24, 2023

Conversation

Junchao-Mellanox
Copy link
Collaborator

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liat-grozovik liat-grozovik changed the title [202205] Fix issue: user must set admin down before toggling LPM [202205] [Mellanox] Fix issue: user must set admin down before toggling LPM Mar 21, 2023
@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit f74c69e into sonic-net:202205 Mar 24, 2023
@Junchao-Mellanox Junchao-Mellanox deleted the fix-lpm branch June 12, 2023 04:36
keboliu added a commit to keboliu/sonic-buildimage that referenced this pull request Nov 7, 2023
@keboliu
Revert "[202205] [Mellanox] Fix issue: user must set admin down befor…
41e38e6 
…e toggling LPM (sonic-net#14370)"

This reverts commit f74c69e.
yxieca pushed a commit that referenced this pull request Dec 12, 2023
@keboliu
[202205] [Mellanox] Revert LPM implementation to the old way (#17179)
2155455 
* Revert "[202205] [Mellanox] Fix issue: user must set admin down before toggling LPM (#14370)"

This reverts commit f74c69e.

* update copyright header

Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keboliu keboliu keboliu approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@prgeor prgeor Awaiting requested review from prgeor

Assignees
No one assigned
Labels
NVIDIA Platform: Mellanox
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Junchao-Mellanox @mssonicbld @keboliu @liat-grozovik @yxieca